From 55f44ba84562d164b3290cf5e2f3e310aa5c9ec1 Mon Sep 17 00:00:00 2001 From: MIchael Haehnel Date: Thu, 12 Oct 2023 19:06:57 +0200 Subject: [PATCH] NOTICKET: Fix lint errors and warnigns --- roles/maria/tasks/_create_backup.yml | 2 +- roles/postgres/tasks/_create_backup.yml | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/roles/maria/tasks/_create_backup.yml b/roles/maria/tasks/_create_backup.yml index 10f8f37..3769295 100644 --- a/roles/maria/tasks/_create_backup.yml +++ b/roles/maria/tasks/_create_backup.yml @@ -35,7 +35,7 @@ # there is no ansible gpg module already in place # linting violation needs to be whitelisted - - name: "Importing stage specific automation gpg-key" # noqa command-instead-of-shell + - name: "Importing stage specific automation gpg-key" # noqa command-instead-of-shell no-changed-when shell: 'gpg --import {{ tempdir.path }}/{{ backup_communication_keys_stage_gpg_key }}' become: yes diff --git a/roles/postgres/tasks/_create_backup.yml b/roles/postgres/tasks/_create_backup.yml index dbabeca..17e7c4c 100644 --- a/roles/postgres/tasks/_create_backup.yml +++ b/roles/postgres/tasks/_create_backup.yml @@ -32,7 +32,7 @@ # there is no ansible gpg module already in place # linting violation needs to be whitelisted - - name: "Importing stage specific automation gpg-key" # noqa command-instead-of-shell + - name: "Importing stage specific automation gpg-key" # noqa command-instead-of-shell no-changed-when shell: "gpg --import {{ tempdir.path }}/{{ backup_communication_keys_stage_gpg_key }}" - name: "Block: Creating pg_basebackup" @@ -63,6 +63,7 @@ copy: content: "{{ backup_result }}" dest: "{{ backup_status_file }}" + mode: "0644" - name: "Change ownership of {{ backup_dest_dir }} to {{ backupuser_user_name }}:{{ backupuser_user_name }}" ansible.builtin.file: @@ -75,6 +76,7 @@ copy: content: "{{ backup_result }}" dest: "{{ backup_status_file }}_with_failures" + mode: "0644" when: backup_result.failed - name: "Rescue: Delete {{ backup_file }} on failure"