From fef5b081b4c7969332bac1997f4036a8f7ac581e Mon Sep 17 00:00:00 2001
From: LeeW <lee.watson@netgo.de>
Date: Wed, 26 Feb 2025 16:53:02 +0100
Subject: [PATCH] updates instructions

---
 README.md | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index f125f64..cff4daf 100644
--- a/README.md
+++ b/README.md
@@ -5,11 +5,19 @@ Purpose: Manage gpg keys for:
 
 # Key Management
 
-## 1. Onboarding: howto create and add a gpg key
+Roles:
+
+* New User: new key to be added; can be a new employee being added for first time, existing employee getting access to a new repo, key rotation, etc
+* Existing User: user who already has access to the appropriate project
+* Any User: either New User or Existing User
+
+## 1. Onboarding: New User: create and add a gpg key
 - please follow instruction on following link: https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key
 - add ONLY the _PUBLIC_ part of your gpg key!!!
 - checkin via MergeRequest/PullRequest
 
+# TODO
+## Reference: Manual Steps
 ### import gpg keys
 ```shell
 gpg --import /path/to/keys/*.gpg.pub
@@ -21,16 +29,20 @@ gpg --list-keys --keyid-format=long
 ```
 
 
-### groups
+### 1b. Onboarding: Any User: Add new user to groups
 
 Access for each repo is tracked using the `./groups/` directory; each sub-directory represents a "group" (Note: some "groups" are also "roles", e.g. `admin`)
 
+Most of the groups correspond directly to git repository names, aka "project name"
+
 ```bash
 cd groups/<project_name>
 ln -s ../../<path_to_key.gpg.pub>
 ```
 
-## 2. Offboarding: Archive Expired Keys (EOL)
+Note: this step can be performed by anyone (either new user or existing user), but it makes the most sense for an existing user to configure the groups since this is domain-specific knowledge (i.e. new users won't typically know the grups)
+
+## 2. Offboarding: Any User: Archive Expired Keys (EOL)
 
 To mark a key as expired, move it to the `archive/` dir as follows:
 
@@ -38,7 +50,7 @@ To mark a key as expired, move it to the `archive/` dir as follows:
 mv ${keyname} "archive/${keyname}_$(date '+%Y-%m-%d').archive"
 ```
 
-## 3. Configure sops config
+## 3. Existing User: Configure sops config
 
 Context: This repo stores the keys used to encrypt secrets in other repos; these "consumer" repos each contain a sops config `.sops.yaml` which manages access to the encrypted files (e.g. `secrets.yaml`)